Merged
Conversation
For more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 83.48% 83.74% +0.25%
==========================================
Files 28 29 +1
Lines 4008 4084 +76
==========================================
+ Hits 3346 3420 +74
- Misses 662 664 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Todo:
|
* Allow a domain keyword file to update the following aspects of an existing keyword: - make the conformance more strict - extend the domain - change the default value * Any other change is an error. * Factored out general functions to a new dictutils.py module * Made the use of keywords more consistent * Added more tests and fixed related issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made the following changes:
Added
wasDerivedFromto the default keywords.Generalised
basedOnin a keywords file. It can now be a domain (str), file path (Path) or a list of them. It can now also fetch from the web.Allow a domain keyword file to update the following aspects of an existing keyword:
Any other change is an error.
Factored out general functions to a new dictutils.py module
Made the use of keywords more consistent
Added more tests and fixed related issues
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.