Skip to content

Fixed minor bugs in keywords.py#432

Merged
jesper-friis merged 16 commits intomasterfrom
fix-keywords
Sep 28, 2025
Merged

Fixed minor bugs in keywords.py#432
jesper-friis merged 16 commits intomasterfrom
fix-keywords

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Sep 25, 2025

Description

Made the following changes:

  • Added wasDerivedFrom to the default keywords.

  • Generalised basedOn in a keywords file. It can now be a domain (str), file path (Path) or a list of them. It can now also fetch from the web.

  • Allow a domain keyword file to update the following aspects of an existing keyword:

    • make the conformance more strict
    • extend the domain
    • change the default value

    Any other change is an error.

  • Factored out general functions to a new dictutils.py module

  • Made the use of keywords more consistent

  • Added more tests and fixed related issues

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 90.07092% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.74%. Comparing base (41545d4) to head (68de25f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tripper/datadoc/keywords.py 86.27% 7 Missing ⚠️
tripper/datadoc/dictutils.py 90.90% 5 Missing ⚠️
tripper/utils.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   83.48%   83.74%   +0.25%     
==========================================
  Files          28       29       +1     
  Lines        4008     4084      +76     
==========================================
+ Hits         3346     3420      +74     
- Misses        662      664       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesper-friis jesper-friis changed the title Fixed some minor bugs in keywords.py Fixed minor bugs in keywords.py Sep 26, 2025
@jesper-friis
Copy link
Contributor Author

Todo:

  • add tests
  • allow basedOn to fetch a root from the web
  • be strict on what can be changed of existing keywords (only make conformance stricter and add default values)

jesper-friis and others added 9 commits September 27, 2025 22:22
* Allow a domain keyword file to update the following aspects of an existing keyword:
  - make the conformance more strict
  - extend the domain
  - change the default value
* Any other change is an error.
* Factored out general functions to a new dictutils.py module
* Made the use of keywords more consistent
* Added more tests and fixed related issues
@jesper-friis jesper-friis requested review from francescalb and removed request for francescalb September 28, 2025 10:37
@jesper-friis jesper-friis merged commit 570a9bb into master Sep 28, 2025
22 checks passed
@jesper-friis jesper-friis deleted the fix-keywords branch September 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant