Skip to content

Added keywords hasCurator and hasCurationDate#405

Merged
jesper-friis merged 8 commits intomasterfrom
hasCurator
May 26, 2025
Merged

Added keywords hasCurator and hasCurationDate#405
jesper-friis merged 8 commits intomasterfrom
hasCurator

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented May 24, 2025

Description

  • Added keywords hasCurator and hasCurationDate.
  • Added support for xsd:date in literals.py. Needed by hasCurationDate.

Closes #390

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@jesper-friis jesper-friis requested a review from francescalb May 24, 2025 14:21
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (e2791c3) to head (2ace24f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          28       28           
  Lines        3903     3903           
=======================================
  Hits         3246     3246           
  Misses        657      657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

| [type] | [skos:Concept] | optional | A type of the resource. | A recommended controlled vocabulary data-type is foreseen. |
| [version] | [rdfs:Literal] | optional | Version indicator (name or identifier) of a resource. | |
| [versionNotes] | [rdfs:Literal] | optional | A description of the differences between this version and a previous version of the resource. | This property can be repeated for parallel language versions of the version notes. |
| [hasCurationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `hasCurator`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced about hasCurationDate. This is something that refers back to a day in the past.

How about wasCuratedOn and wasCuratedBy, to identify who did what when. However these have to be linked somehow. Can this be done simply with triples?.

hasCurator I would think is the person(s) who are still in charge of the data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with curatedBy and curationDate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage note about curationDate should not be used without curatedBy. Can later be enforced by validate()

| [hasCurationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `hasCurator`. |
| [hasCurator] | [foaf:Agent] | | The agent that curated the resource. | |
| [curatedBy] | [foaf:Agent] | | The agent that curated the resource. | |
| [curationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `curatedBy`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the date will be too restrictive. Curation typically wil take place over more than one day. Or are we talking aobut the resource was documented.

@jesper-friis jesper-friis enabled auto-merge (squash) May 26, 2025 12:25
@jesper-friis jesper-friis merged commit 71525d1 into master May 26, 2025
20 checks passed
@jesper-friis jesper-friis deleted the hasCurator branch May 26, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hasCurator and hasCurationDate properties to resources

2 participants