Added keywords hasCurator and hasCurationDate#405
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 28 28
Lines 3903 3903
=======================================
Hits 3246 3246
Misses 657 657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/datadoc/keywords.md
Outdated
| | [type] | [skos:Concept] | optional | A type of the resource. | A recommended controlled vocabulary data-type is foreseen. | | ||
| | [version] | [rdfs:Literal] | optional | Version indicator (name or identifier) of a resource. | | | ||
| | [versionNotes] | [rdfs:Literal] | optional | A description of the differences between this version and a previous version of the resource. | This property can be repeated for parallel language versions of the version notes. | | ||
| | [hasCurationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `hasCurator`. | |
There was a problem hiding this comment.
I am not convinced about hasCurationDate. This is something that refers back to a day in the past.
How about wasCuratedOn and wasCuratedBy, to identify who did what when. However these have to be linked somehow. Can this be done simply with triples?.
hasCurator I would think is the person(s) who are still in charge of the data?
There was a problem hiding this comment.
Replace with curatedBy and curationDate
There was a problem hiding this comment.
Add usage note about curationDate should not be used without curatedBy. Can later be enforced by validate()
docs/datadoc/keywords.md
Outdated
| | [hasCurationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `hasCurator`. | | ||
| | [hasCurator] | [foaf:Agent] | | The agent that curated the resource. | | | ||
| | [curatedBy] | [foaf:Agent] | | The agent that curated the resource. | | | ||
| | [curationDate] | [rdfs:Literal]<br>(xsd:date) | | The date the resource was curated. | Should be used with `curatedBy`. | |
There was a problem hiding this comment.
I wonder if the date will be too restrictive. Curation typically wil take place over more than one day. Or are we talking aobut the resource was documented.
Description
hasCuratorandhasCurationDate.xsd:datein literals.py. Needed byhasCurationDate.Closes #390
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.