Skip to content

added a file about how to search and delete resources in the ts#397

Merged
francescalb merged 24 commits intomasterfrom
flb/update-documentation-search-delete
May 26, 2025
Merged

added a file about how to search and delete resources in the ts#397
francescalb merged 24 commits intomasterfrom
flb/update-documentation-search-delete

Conversation

@francescalb
Copy link
Contributor

@francescalb francescalb commented May 22, 2025

Description

partially closes 396 and 389

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Base automatically changed from criteria_update_and_doc to master May 23, 2025 06:43
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (f908bac) to head (7c61e59).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   83.11%   83.16%   +0.05%     
==========================================
  Files          28       28              
  Lines        3897     3903       +6     
==========================================
+ Hits         3239     3246       +7     
+ Misses        658      657       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@francescalb francescalb linked an issue May 23, 2025 that may be closed by this pull request
@francescalb francescalb marked this pull request as ready for review May 23, 2025 13:40

Similarly the load function can be used to fetch the data using the information about the dowload URL in the metadata.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an example of how to use load() can be added here...

Very nice. Added a few suggestions
Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation and useful to be able to add multible types or criteria values.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an additional suggestion that hopefully should fix the failing tests

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion for fixing failing test

@francescalb francescalb merged commit e2791c3 into master May 26, 2025
85 of 121 checks passed
@francescalb francescalb deleted the flb/update-documentation-search-delete branch May 26, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

correct criterias to criteria

2 participants