Skip to content

Update using criteria in search#395

Merged
francescalb merged 2 commits intomasterfrom
criteria_update_and_doc
May 23, 2025
Merged

Update using criteria in search#395
francescalb merged 2 commits intomasterfrom
criteria_update_and_doc

Conversation

@francescalb
Copy link
Contributor

Description

Updated criterias to criteria, started on documentation to fetch data

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (09f9e39) to head (e422118).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
tripper/datadoc/dataset.py 70.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   83.20%   83.11%   -0.10%     
==========================================
  Files          28       28              
  Lines        3883     3897      +14     
==========================================
+ Hits         3231     3239       +8     
- Misses        652      658       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@francescalb francescalb marked this pull request as ready for review May 20, 2025 08:23
@francescalb francescalb requested a review from jesper-friis May 20, 2025 08:28
Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra

@francescalb francescalb merged commit 3bdda69 into master May 23, 2025
18 of 20 checks passed
@francescalb francescalb deleted the criteria_update_and_doc branch May 23, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants