Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 82.17% 81.69% -0.48%
==========================================
Files 28 28
Lines 3775 3775
==========================================
- Hits 3102 3084 -18
- Misses 673 691 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francescalb
reviewed
May 2, 2025
francescalb
reviewed
May 2, 2025
francescalb
reviewed
May 2, 2025
francescalb
reviewed
May 2, 2025
tripper/units/units.py
Outdated
Comment on lines
1051
to
1053
| 3. If two units have the same sum, the unit that minimises | ||
| `log10(magnitude/5)` is selected, where magnitude of this | ||
| quantity when expressed in SI base units. |
Contributor
There was a problem hiding this comment.
Not a complete sentence, and I do not understasnd it.
Contributor
Author
There was a problem hiding this comment.
Is it the example in point 2 that you don't understand.
Contributor
There was a problem hiding this comment.
It is point 3. There is something wrong in the sentence. What does "where magnitude of this
quantity when expressed in SI base units" mean?
francescalb
requested changes
May 2, 2025
Contributor
francescalb
left a comment
francescalb
left a comment
There was a problem hiding this comment.
Please check comments
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
francescalb
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the test_markdown_doctest() test such that it fails properly when doctest finds an error in the markdown documentation.
Also fixed failing examples in the documentation revealed by the above fix.
The reduced test coverage is due to correcting some previously failing doctests. Since we don't know whether the user has a
~/.config/tripper/session.yamlor not, we cannot test callingSession()without argument since we don't know whether it will fail or not.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.