Merged
Conversation
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 80.44% 80.43% -0.01%
==========================================
Files 25 25
Lines 2971 2970 -1
==========================================
- Hits 2390 2389 -1
Misses 581 581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francescalb
reviewed
Mar 28, 2025
README.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| <img src="https://raw.githubusercontent.com/EMMC-ASBL/tripper/refs/heads/tripper_logo/docs/figs/tripper_logo.svg" alt="Tripper logo" align="right" width="72" height="72"> | |||
Contributor
There was a problem hiding this comment.
This will not resolve correctly once the PR is merged
Contributor
Author
There was a problem hiding this comment.
Very good point. The links are now updated to master
francescalb
reviewed
Mar 28, 2025
docs/index.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| <img src="https://raw.githubusercontent.com/EMMC-ASBL/tripper/refs/heads/tripper_logo/figs/tripper_logo.svg" alt="Tripper logo" align="right" width="72" height="72"> | |||
Contributor
There was a problem hiding this comment.
Wrong path, also within this PR.
francescalb
reviewed
Mar 28, 2025
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
For more information, see https://pre-commit.ci
francescalb
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the logos created by @francescalb
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.