Test for the datadoc command-line tool#361
Merged
jesper-friis merged 35 commits intomasterfrom Mar 26, 2025
Merged
Conversation
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
…nto test-for-datadoc-cli
10 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 78.01% 80.44% +2.43%
==========================================
Files 25 25
Lines 2929 2971 +42
==========================================
+ Hits 2285 2390 +105
+ Misses 644 581 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jesper-friis
commented
Mar 26, 2025
| if "=~" in crit: | ||
| key, value = crit.split("=~", 1) | ||
| regex[key] = value | ||
| else: |
Contributor
Author
There was a problem hiding this comment.
Example of strange codecov report:
subcommand_delete()is definitely called bytest_delete()in test_datadoc_dli.py. So line 51-53 must be covered.- Why can line 58 be covered when line 51-57 aren't?
francescalb
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests for datadoc cli.
This PR also include some fixes, code restructuring and new features revealed or needed by the tests:
The codecov report is very strange - the reported untested code lines are definitely included in the tests added in this PR. Can it be looking at an old branch? (The indicated untested code lines doesn't follow the logical flow of the code).
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.