WIP: Add support for dicts with @graph keywords#360
Closed
jesper-friis wants to merge 8 commits intomasterfrom
Closed
WIP: Add support for dicts with @graph keywords#360jesper-friis wants to merge 8 commits intomasterfrom
jesper-friis wants to merge 8 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 82.26% 82.18% -0.08%
==========================================
Files 27 27
Lines 3439 3452 +13
==========================================
+ Hits 2829 2837 +8
- Misses 610 615 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
jesper-friis
added a commit
that referenced
this pull request
Mar 29, 2025
From the data documentation in COLD we learned that it is useful to also include the classes in the JSON-LD context.
This makes it e.g. possible to short names when referring to classes in JSON-LD files. Ex: `{"@type": "Resource", ...}`
This PR is also used in PR #360 to replace keywords with JSON-LD context in many parts of the dataset API. The benefit with this is that this allows to use existing externally defined JSON-LD contexts.
Also added a `__dir__()` method to Keywords that include the documented attributes. It simplifies interactive exploration of Keyword instances using ipython (used while implementing this PR).
10 tasks
jesper-friis
added a commit
that referenced
this pull request
Apr 22, 2025
# Description We are in a state with many open PRs with mutual conflicts. This branch merge them together and resolve conflicts. It merges the following branches: - context-module, PR #378 - keyword_bugs, PR #375 - master - matchmaker-demo, PR #377 - fix-readme-link, PR #379 - use_pyld, PR #376 Furthermore it has added support for the graph keyword (in a better way), replacing PR #360 as well. See [Tripper network](https://github.com/EMMC-ASBL/tripper/network) for details. The speed of tabledoc has been greatly improved. The PINK example with 1021 datasets now runs in a few seconds compared to minutes before... --------- Co-authored-by: Francesca.L.Bleken@sintef.no <francesca.l.bleken@sintef.no>
Contributor
Author
|
Closing since a better solution solution was included in PR #380 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update save_dict() to allow dicts containing a top-level "@graph" keyword with a list of dicts to save
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.