Skip to content

Added test for Fuseki and fixed query to return TURTLE which works for both fuseki and graphdb#347

Merged
francescalb merged 6 commits intomasterfrom
flb/sparql_fuseki
Feb 28, 2025
Merged

Added test for Fuseki and fixed query to return TURTLE which works for both fuseki and graphdb#347
francescalb merged 6 commits intomasterfrom
flb/sparql_fuseki

Conversation

@francescalb
Copy link
Contributor

Description

Added test for Fuseki and fixed query to return TURTLE which works for both fuseki and graphdb

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (060c3a4) to head (9fcc8a5).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
tripper/backends/sparqlwrapper.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   76.75%   77.49%   +0.74%     
==========================================
  Files          22       22              
  Lines        2512     2515       +3     
==========================================
+ Hits         1928     1949      +21     
+ Misses        584      566      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


def fuseki_available():
"""
Help function that checks if the Fuseki instance is available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Help function that checks if the Fuseki instance is available
Help function that returns True if the Fuseki instance is available

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very nice to include run a Fuseki instance during CI testing.

Looks good. But I have not had time to test it...

@francescalb francescalb merged commit 4745506 into master Feb 28, 2025
19 checks passed
@francescalb francescalb deleted the flb/sparql_fuseki branch February 28, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants