Skip to content

Fixed CONSTRUCT to return s and not o#338

Merged
francescalb merged 5 commits intomasterfrom
flb/construct_returns_toomuch
Feb 19, 2025
Merged

Fixed CONSTRUCT to return s and not o#338
francescalb merged 5 commits intomasterfrom
flb/construct_returns_toomuch

Conversation

@francescalb
Copy link
Contributor

Description

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (8991de4) to head (b9f9129).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   76.67%   76.68%           
=======================================
  Files          22       22           
  Lines        2508     2509    +1     
=======================================
+ Hits         1923     1924    +1     
  Misses        585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@francescalb francescalb merged commit f30f666 into master Feb 19, 2025
19 checks passed
@francescalb francescalb deleted the flb/construct_returns_toomuch branch February 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CONSTRUCT sparql query in _load_sparql used in load_dict returns all datasets

2 participants