Skip to content

Update dataset.py#325

Merged
jesper-friis merged 2 commits intomasterfrom
jesper-friis-patch-1
Feb 13, 2025
Merged

Update dataset.py#325
jesper-friis merged 2 commits intomasterfrom
jesper-friis-patch-1

Conversation

@jesper-friis
Copy link
Contributor

Description

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.83%. Comparing base (3b32425) to head (af00a56).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   76.83%   76.83%           
=======================================
  Files          22       22           
  Lines        2491     2491           
=======================================
  Hits         1914     1914           
  Misses        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 917 to 921
List IRIs of all datasets who's title matches a given regular expression:

search_iris(
ts, contactPoint="John Doe", fromSample=SAMPLE.batch2/sample3
ts, critetia={"contactPoint": "John Doe", "fromSample": SAMPLE.batch2/sample3}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not use regex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@torhaugl torhaugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation update. Looks good

@jesper-friis jesper-friis merged commit fb5c77e into master Feb 13, 2025
19 checks passed
@jesper-friis jesper-friis deleted the jesper-friis-patch-1 branch February 13, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants