Include prefixes from context when populating a triplestore from a csv file#309
Merged
jesper-friis merged 7 commits intomasterfrom Jan 20, 2025
Merged
Include prefixes from context when populating a triplestore from a csv file#309jesper-friis merged 7 commits intomasterfrom
jesper-friis merged 7 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 76.85% 76.87% +0.01%
==========================================
Files 22 22
Lines 2467 2469 +2
==========================================
+ Hits 1896 1898 +2
Misses 571 571 ☔ View full report in Codecov by Sentry. |
francescalb
requested changes
Jan 20, 2025
Contributor
francescalb
left a comment
There was a problem hiding this comment.
Looks fine, but as it is a bug test it is clear that it is a feature that was not sufficiently tested. I would like a test for it.
francescalb
approved these changes
Jan 20, 2025
Contributor
Author
Added a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include prefixes from context when populating a triplestore from a csv file.
Also made the
typeargument ofsave_dict()optional in order to be consistent withas_jsonld().Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.