Skip to content

Include prefixes from context when populating a triplestore from a csv file#309

Merged
jesper-friis merged 7 commits intomasterfrom
save_csv_prefixes
Jan 20, 2025
Merged

Include prefixes from context when populating a triplestore from a csv file#309
jesper-friis merged 7 commits intomasterfrom
save_csv_prefixes

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 16, 2025

Description

Include prefixes from context when populating a triplestore from a csv file.

Also made the type argument of save_dict() optional in order to be consistent with as_jsonld().

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.87%. Comparing base (be2c21e) to head (7186882).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   76.85%   76.87%   +0.01%     
==========================================
  Files          22       22              
  Lines        2467     2469       +2     
==========================================
+ Hits         1896     1898       +2     
  Misses        571      571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but as it is a bug test it is clear that it is a feature that was not sufficiently tested. I would like a test for it.

@jesper-friis
Copy link
Contributor Author

Looks fine, but as it is a bug test it is clear that it is a feature that was not sufficiently tested. I would like a test for it.

Added a test.

@jesper-friis jesper-friis merged commit f6f859c into master Jan 20, 2025
19 checks passed
@jesper-friis jesper-friis deleted the save_csv_prefixes branch January 20, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants