Skip to content

Implementing regex search#307

Merged
jesper-friis merged 5 commits intomasterfrom
find-regex
Feb 4, 2025
Merged

Implementing regex search#307
jesper-friis merged 5 commits intomasterfrom
find-regex

Conversation

@jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 14, 2025

Description

Replaced the "contains" search with the more general "regex" search.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.87%. Comparing base (f6f859c) to head (9271c85).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tripper/datadoc/clitool.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files          22       22           
  Lines        2469     2469           
=======================================
  Hits         1898     1898           
  Misses        571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis changed the title WIP: Started implementing regex search Implementing regex search Jan 20, 2025
@jesper-friis jesper-friis merged commit b2ece20 into master Feb 4, 2025
18 of 19 checks passed
@jesper-friis jesper-friis deleted the find-regex branch February 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant