Merged
Conversation
- Allow to add other types of entries to the triplestore that are not
datasets. Ex: samples, models, instruments, people, projects...
- Renamed list_data_iris() to search_iris(). It can now be use to search
for all types of entries.
- Renamed prepare() to as_jsonld() and made it part of the public API
For more information, see https://pre-commit.ci
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 78.69% 79.18% +0.49%
==========================================
Files 21 21
Lines 2229 2263 +34
==========================================
+ Hits 1754 1792 +38
+ Misses 475 471 -4 ☔ View full report in Codecov by Sentry. |
For more information, see https://pre-commit.ci
…t.json to match the order in datadoc-keywords.md
torhaugl
approved these changes
Jan 3, 2025
Contributor
torhaugl
left a comment
There was a problem hiding this comment.
Mostly improved documentation. I think a link to JSON-LD playground would be nice in the customization part. I'll let you decide if you want to commit these changes before merging.
I did not read all the descriptions for the pre-defined keywords in detail, but a quick glance and they look reasonable. Includes a new function openfile (to open over http) and corresponding test.
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
For more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for datasets. Other changes:
backendsintripper.__init__.pyto avoid pytest failing withRuntimeError: dictionary changed size during iterationwhen collectingtripper.__init__.py.The documentation can be checked locally with:
Builds on top of PR #279
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.