Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 79.39% 78.35% -1.04%
==========================================
Files 18 17 -1
Lines 1742 1737 -5
==========================================
- Hits 1383 1361 -22
- Misses 359 376 +17 ☔ View full report in Codecov by Sentry. |
francescalb
reviewed
Dec 11, 2024
pyproject.toml
Outdated
| [tool.pytest.ini_options] | ||
| minversion = "7.0" | ||
| addopts = "-rs --cov=tripper --cov-report=term --doctest-modules" | ||
| addopts = "-rs --cov=tripper --cov-report=term --doctest-modules --ignore=examples --ignore=tripper" |
Contributor
There was a problem hiding this comment.
Suggested change
| addopts = "-rs --cov=tripper --cov-report=term --doctest-modules --ignore=examples --ignore=tripper" | |
| addopts = "-rs --cov=tripper --cov-report=term --doctest-modules --ignore=examples" |
I also do not like ignoring of examples, but tripper which is our code-base should definitely not be ignored.
Contributor
Author
There was a problem hiding this comment.
I also do not like ignoring of examples, but tripper which is our code-base should definitely not be ignored.
Replaced it with new --doctest-ignore-import-errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for Python 3.13.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.