Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 78.34% 78.41% +0.07%
==========================================
Files 18 18
Lines 1690 1696 +6
==========================================
+ Hits 1324 1330 +6
Misses 366 366 ☔ View full report in Codecov by Sentry. |
francescalb
reviewed
Jun 24, 2024
francescalb
reviewed
Jun 24, 2024
francescalb
reviewed
Jun 24, 2024
francescalb
reviewed
Jun 24, 2024
francescalb
reviewed
Jun 24, 2024
francescalb
requested changes
Jun 24, 2024
Contributor
francescalb
left a comment
There was a problem hiding this comment.
Some suggested changes to the tutorial, but only wording. It looks very good!
I think we should change to return_dicts = True as default as also changing target to value is a breaking change. We just have to state very clearly in the release that this is done, and that thisis a breaking change on a a feature that was added in the previous realease.
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
… changed the default to True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a
return_dictskeyword argument to theTriplestore.retrictions()method, to allow to get the restrictions as dicts instead of blank nodes.Other changes:
targetargument ofTriplestore.add_retriction()andTriplestore.retrictions()tovaluein order to be consistent with the naming in EMMOntoPy. These two methods are a very new addition to tripper that haven't been used yet. This change that this change will break existing code is therefore very small.Question
Should we change the default of
return_dictsto be true? If so, this is the right time to do it, before people starts to use these methods.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.