Conversation
CasperWA
left a comment
There was a problem hiding this comment.
It seems there were some changes at the top of files that seem to be the beginning of further changes that were then never made?
Also, please add the self.headers usage for all resource classes under services for all requests.
|
Hi @CasperWA, this PR is way overdue, I will take a look tomorrow ASAP. Sorry for that! |
|
I tried to update it as best I could, concerning the latest PR with major changes for the client implementation. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 90.48% 90.82% +0.33%
==========================================
Files 25 26 +1
Lines 389 425 +36
==========================================
+ Hits 352 386 +34
- Misses 37 39 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Only a single custom warning is used for now, which is to warn the user if any given configuration options for the clients are not actually used.
|
I added a |
|
@MBueschelberger I am unfortunately running out of work hours. Is there anything here that still needs to be addressed? Maybe one of your comments above to my review? That's about it what I can understand? |
Description:
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.
Related to the implementations from this PR, a simple inclusion of the http-headers into the request-objects for the services has been added.
Since there are multiple ways to fetch and pass an access-token from a broker to an application, I think it makes sense to only pass custom headers for now when the
OTEClientis launched.E.g. if a sophisticated solution in the services requires an API-token from an identity broker, the related secret cannot be simply retrieved by basic http-logins with user/password on a script basis.
Since I do not provide a generic solution with this PR, the user needs to be able to set his own headers. A generic solution might be to complex for the time remaining in the use case.