Skip to content

Use pipe (|) instead of colon (:) for plugins#84

Merged
CasperWA merged 3 commits intomasterfrom
cwa/fix-81-pipe-delim
Mar 15, 2022
Merged

Use pipe (|) instead of colon (:) for plugins#84
CasperWA merged 3 commits intomasterfrom
cwa/fix-81-pipe-delim

Conversation

@CasperWA
Copy link
Contributor

Fixes #81

@CasperWA CasperWA requested a review from jesper-friis March 11, 2022 10:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #84 (833835c) into master (53373d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          15       15           
  Lines         414      414           
=======================================
  Hits          282      282           
  Misses        132      132           
Flag Coverage Δ
pytest 68.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53373d6...833835c. Read the comment docs.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@CasperWA CasperWA requested a review from jesper-friis March 14, 2022 10:30
@CasperWA CasperWA dismissed jesper-friis’s stale review March 15, 2022 15:22

Changes are succeeding

@CasperWA CasperWA merged commit 30f5a01 into master Mar 15, 2022
@CasperWA CasperWA deleted the cwa/fix-81-pipe-delim branch March 15, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use different delimiter for OTEAPI_PLUGIN_PACKAGES

3 participants