Merged
Conversation
This is only available for the `development` Dockerfile target.
The `construct()` method of pydantic models doesn't actually "cast" the input values to the desired attribute types, e.g., not converting a string to a URL type - this is very undesired.
Test PATH_TO_OTEAPI_CORE in CI.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 15 15
Lines 414 414
=======================================
Hits 282 282
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
A default is set through the docker-compose_dev.yml file, however if not using docker compose, but straightup docker, this will fail currently. Adds a check to see whether PATH_TO_OTEAPI_CORE even exists/is empty or not.
jesper-friis
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
Closes #66