Skip to content

Add new workflow CD publish job#43

Merged
CasperWA merged 8 commits intomasterfrom
cwa/close-11-publish-container-image-on-gh-packages
Feb 9, 2022
Merged

Add new workflow CD publish job#43
CasperWA merged 8 commits intomasterfrom
cwa/close-11-publish-container-image-on-gh-packages

Conversation

@CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Feb 8, 2022 •
edited
Loading

This job runs on every push to master and will publish a container
(Docker) image on GH Packages.

Closes #11

To do:

  • Test the job run by temporarily publishing from this branch.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #43 (9cfdcbc) into master (751c2ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files           8        8           
  Lines         295      295           
=======================================
  Hits          205      205           
  Misses         90       90
Flag Coverage Δ
pytest 69.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751c2ea...9cfdcbc. Read the comment docs.

@CasperWA
Copy link
Contributor Author

CasperWA commented Feb 8, 2022

The publishing seems to work: https://github.com/EMMC-ASBL/oteapi-services/pkgs/container/oteapi

@CasperWA
Revert testing CI job
118b00d 
Remove comments in CI job
@CasperWA
Update docker compose with GH Package image
6c65cfe 
Use a new docker-compose_dev file for CI and to ease development.
Add the mapping to the local files for the dev file.

Extend the Dockerfile development target with `--debug` and
`--log-level=debug`.

Update the README accordingly.
@CasperWA CasperWA marked this pull request as ready for review February 8, 2022 15:05
@CasperWA CasperWA requested a review from jesper-friis February 8, 2022 15:05
@CasperWA CasperWA mentioned this pull request Feb 8, 2022
Merged
jesper-friis
jesper-friis approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, but I think it is even more important to run this CI on the GitLab oteapi-deploy repo and deploy to the GitLab docker registry...

@CasperWA
Copy link
Contributor Author

CasperWA commented Feb 9, 2022

Nice PR, but I think it is even more important to run this CI on the GitLab oteapi-deploy repo and deploy to the GitLab docker registry...

True. This is a separate issue however, as that will be the OntoTrans-specific version. It should be setup there. Possibly discuss with @quaat on how to do this best?

@CasperWA CasperWA merged commit 2f1c3dd into master Feb 9, 2022
@CasperWA CasperWA deleted the cwa/close-11-publish-container-image-on-gh-packages branch February 9, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesper-friis jesper-friis jesper-friis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maybe publish Docker image on GitHub Packages

3 participants

@CasperWA @codecov-commenter @jesper-friis