Skip to content

Add Docker Compose file and update README#59

Merged
CasperWA merged 4 commits intomasterfrom
cwa/close-57-docker-compose-dev
Mar 11, 2022
Merged

Add Docker Compose file and update README#59
CasperWA merged 4 commits intomasterfrom
cwa/close-57-docker-compose-dev

Conversation

@CasperWA
Copy link
Contributor

Closes #57

To see the updated README go here.

@CasperWA CasperWA requested review from kriwiik and sygout March 11, 2022 14:05
@sygout
Copy link

sygout commented Mar 11, 2022

Looks nice. but 2 questions:

  • it seems that the text is duplicated. why? it is possible to use a reference?
  • sentence : " Note, remember to update setup.cfg to list the plugin strategies - otherwise they will not be findable by the OTEAPI service." is it specific to the service test or a generic remark for the plug-in development?

@CasperWA
Copy link
Contributor Author

  • it seems that the text is duplicated. why? it is possible to use a reference?

Which text do you mean explicitly?

  • sentence : " Note, remember to update setup.cfg to list the plugin strategies - otherwise they will not be findable by the OTEAPI service." is it specific to the service test or a generic remark for the plug-in development?

This is how the plugin system works - so this is general.

@sygout
Copy link

sygout commented Mar 11, 2022

text in these two files:
{{ cookiecutter.project_slug }}/docs/index.md
{{ cookiecutter.project_slug }}/README.md

"This is how the plugin system works - so this is general." then i would put it at the start of the Test the plugin section. So that it is more visible

Otherwise I see that a CI test if failing.

@CasperWA
Copy link
Contributor Author

text in these two files: {{ cookiecutter.project_slug }}/docs/index.md {{ cookiecutter.project_slug }}/README.md

"This is how the plugin system works - so this is general." then i would put it at the start of the Test the plugin section. So that it is more visible

Otherwise I see that a CI test if failing.

Ah - the index.md file is generated from the README.md. Hence the similar text :)
One is essentially a copy of the other, with some tricks to fix the links.

@CasperWA CasperWA enabled auto-merge (squash) March 11, 2022 16:22
@CasperWA
Copy link
Contributor Author

Ah - the index.md file is generated from the README.md. Hence the similar text :) One is essentially a copy of the other, with some tricks to fix the links.

For more information on how this is done, see the pre-commit hooks config file and the associated invoke task.

Note that the latter has been updated in the current PR.

@CasperWA CasperWA merged commit 386f622 into master Mar 11, 2022
@CasperWA CasperWA deleted the cwa/close-57-docker-compose-dev branch March 11, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docker-compose file for development

2 participants