Skip to content

Updated the function strategy #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated the function strategy #8

wants to merge 1 commit into from

Conversation

jesper-friis
Copy link
Contributor

Description:

Create an explicit instance of ASEDliteConfig to make optional attributes available. This is needed, since
self.function_config.configuration is an AttrDict and not an ASEDliteConfig.

@jesper-friis
Updated the function strategy.
92f5679 
Create an explicit instance of ASEDliteConfig to make optional
attributes available.  This is needed, since
`self.function_config.configuration` is an AttrDict and not an
ASEDliteConfig.
francescalb
francescalb requested changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see that the tests that new features are implemented.
It looks fine, but if this is done because a new feature is needed I think it should be refleceted in a (new) test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesper-friis @francescalb