Upgrade to be able to handle svelte 5 features #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module js and ts support Update tests for new warnings Add tests for module js and ts support Update dependency to svelte 5
|
Closes #250 |
This comment was marked as off-topic.
This comment was marked as off-topic.
EMH333
reviewed
Oct 29, 2024
There was a problem hiding this comment.
This is a great start!
Test failure in Node 16 is due to Svelte 5 bumping minimum version to Node 18. I think this is fine to follow, even if the release will still support Svelte >=4.2.1 since v16 has been end of life for a while now. Folks can still use older versions of esbuild-svelte if they need compatibility.
EMH333
changed the title
ElijahJohnson5
force-pushed
the
feature/svelte5
branch
from
9951072
to
883744b
Compare
ElijahJohnson5
force-pushed
the
feature/svelte5
branch
from
31ae8e1
to
c331f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add module js and ts support
Update tests for new warnings
Add tests for module js and ts support
Update dependency to svelte 5
I am open to any changes! Hope this helps get the svelte 5 support across the line.