-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug where some specific shapes make inference on cuda graphs crashing #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pommedeterresautee
added
bug
Something isn't working
benchmark
Measure, measure, measure
labels
Nov 13, 2022
github-actions
bot
added
fix
hurrah, bug fixed!
and removed
fix
hurrah, bug fixed!
labels
Nov 13, 2022
pommedeterresautee
added
triton
triton kernel / implementation
and removed
bug
Something isn't working
benchmark
Measure, measure, measure
labels
Nov 13, 2022
test pass
|
github-actions
bot
added
fix
hurrah, bug fixed!
and removed
fix
hurrah, bug fixed!
labels
Nov 14, 2022
Merged
following new changes:
also tested and pass:
|
gaetansnl
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #176
Also remove the need for a workaround regarding 32x32 issue, etc. -> new shapes have been added in the test suite.