Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify tests #159

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Conversation

pommedeterresautee
Copy link
Member

remove recently added tests (#158) and merged it in the existing suite

@pommedeterresautee pommedeterresautee added the benchmark Measure, measure, measure label Nov 5, 2022
@pommedeterresautee pommedeterresautee self-assigned this Nov 5, 2022
@pommedeterresautee
Copy link
Member Author

pytest test/test_attention.py
===================================================================================================== test session starts =====================================================================================================
platform linux -- Python 3.9.15, pytest-7.2.0, pluggy-1.0.0
rootdir: /mnt/workspace/kernl
plugins: anyio-3.6.1
collected 1082 items           
...
======================================================================================== 730 passed, 352 skipped in 600.88s (0:10:00) =========================================================================================

@pommedeterresautee
Copy link
Member Author

all tests

=========================================================================================================== warnings summary ===========================================================================================================
test/test_torchdynamo.py: 20 warnings
  /home/geantvert/.local/share/virtualenvs/kernl/lib/python3.9/site-packages/torch/jit/_check.py:181: UserWarning: The TorchScript type system doesn't support instance-level annotations on empty non-base types in `__init__`. Instead, either 1) use a type annotation in the class body, or 2) wrap the type in `torch.jit.Attribute`.
    warnings.warn("The TorchScript type system doesn't support "

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================================================================== 2486 passed, 368 skipped, 20 warnings in 6416.95s (1:46:56) ======================================================================================

Copy link
Contributor

@gaetansnl gaetansnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thing to fix

pytest.skip("Original Triton implementation doesn't support masks")

# bf16 reduced precision is sensitive to this value
scale = 1.0 if dtype == torch.bfloat16 else 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we rename this ? it will create confusions for sure. It's the max value of input tensors in reality

@pommedeterresautee pommedeterresautee merged commit df6b543 into main Nov 8, 2022
@pommedeterresautee pommedeterresautee deleted the feat/attention_simplification branch November 8, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Measure, measure, measure feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants