Skip to content

Improper Error Handling - Katha-1164 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joffinjoy merged 2 commits into from
Mar 25, 2024
Merged

Improper Error Handling - Katha-1164 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd4cec
Improper Error Handling - Katha-1164
adithyadinesh0412 Mar 25, 2024
dbd5085
review changes
adithyadinesh0412 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/middlewares/jsonBodyParserWithErrors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict'
const bodyParser = require('body-parser')

exports.jsonBodyParserWithErrors = (req, res, next) => {
bodyParser.json({ limit: '50MB' })(req, res, err => {
if (err instanceof SyntaxError || (err && err.type === 'entity.parse.failed')) {
res.status(400).json({
responseCode: 'INVALID_JSON', // response code and message can be customized here
message: 'The JSON provided in the request is invalid or malformed.',
});
} else {
next(err);
}
});
};
3 changes: 2 additions & 1 deletion src/router/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const { routeConfigInjector } = require('@middlewares/routeConfigInjector')
const { rateLimiter } = require('@middlewares/rateLimiter')
const bodyParser = require('body-parser')
const { httpMethods } = require('@constants/httpMethods')
const {jsonBodyParserWithErrors} = require('@middlewares/jsonBodyParserWithErrors')

exports.initializeRouter = (packages) => {
try {
Expand All @@ -24,7 +25,7 @@ exports.initializeRouter = (packages) => {
targetPackagesInjector,
rateLimiter,
bodyParser.urlencoded({ extended: true, limit: '50MB' }),
bodyParser.json({ limit: '50MB' }),
jsonBodyParserWithErrors,
orchestrationController.orchestrationHandler.bind(null, packages)
)
}
Expand Down