-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for event on first frame #251
Conversation
I tested this by removing all data before a frame with an event from a BIN file.
Ideally we would add a test for this as well, to avoid someone in the future thinking: "why is this written so complicated" and then trying to clean it up therein breaking it again. |
This makes sense. If I supply it to you through another channel, could you add it to the test build? I'll write a test for it before merging. |
@wbaccinelli , any chance you could do this, I don't remember by heart how to do it and would need to look up my notes somewhere. |
I was able to add the data to the package myself.
I pushed it as latest (with the option to remove it and restore the previous image as latest). All tests kept running, including a test using the new file. This only changes an existing image. It would be better if we would have the DockerFile that creates it from 0. |
I can add a new dataset to the Docker image, just tell me which one. It's a good idea to add the process to the documentation. We probably also need to tag the images in a smart way, to avoid corrupting the test by mistakenly uploading a new faulty image. |
I just read this comment. In genera, it might be easier to just recreate the Docker image using the Dockerfile and then push it with the tag we want. |
Closes #81
I tested this by removing all data before a frame with an event from a BIN file.