-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update first download page #2812
Open
ablanathtanalba
wants to merge
13
commits into
master
Choose a base branch
from
update-first-download-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablanathtanalba
added
translations
ui
User interface modifications; related to but not the same as the "ux" label
labels
Oct 22, 2021
…es based on browser type
There are some outlying changes for firefox on android that the design team included in their sketches that are not implemented here, mostly because I'm not sure they are necessary (extra translations and images that I'm not entirely sure are helpful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the onboarding page that new Privacy Badger users see when they first install the extension. The primary goal is to float the instructions on disabling Privacy Badger and reporting a broken site to the top of the page, as well as removing outdated copy, and some minor styling changes. I think this fixes #2781
Testing has been done primarily on Chrome (
make runch
) and then switching the user-agent under dev tools > more tools > network conditions