Remove unlimited storage #1848
Merged
Remove unlimited storage #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as the orange on our homepage.
ghostwords
added
ui
|
@terrorist96 The idea here is if you ever run into this problem again, at least we'll know quickly. |
ghostwords
force-pushed
the
remove-unlimitedStorage
branch
from
1d37496
to
9c74b33
Compare
ghostwords
force-pushed
the
remove-unlimitedStorage
branch
from
9c74b33
to
a03b2cb
Compare
|
Made the "get in touch" link more obvious:
|
ghostwords
force-pushed
the
remove-unlimitedStorage
branch
from
60e8a31
to
82de9dc
Compare
andresbase
approved these changes
Jan 30, 2018
ghostwords
added a commit
that referenced
this pull request
Jan 30, 2018
Removed unlimitedStorage, changed the tracker count badge color, added UI alerting of storage errors.
This was referenced Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1745, closes #1747.
This removes
unlimitedStoragefrom the manifest.I also changed the "trackers
detectedblocked" badge color from red to (Badger) orange. Less yelling at the user on basically every page, more on-brand.Finally, to follow up on #1795 (comment), when we fail writing to
chrome.storage.local, we change badge color to red, badge contents to "!", and (reusing the intro reminder widget) show a message in the popup asking the user to let us know about this issue.What the new badge looks like:
What failing to write to storage looks like on the background page:
What it looks like in the popup: