cleanup styling for dropdown portions of popup

EFForg · Apr 14, 2021 · ca7c71d · ca7c71d
1 parent 9af80f2
commit ca7c71d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/src/skin/popup.css b/src/skin/popup.css
@@ -284,18 +284,19 @@ font-size: 16px;
 #options {
     margin-inline-end: 3px;
 }
-#pbInstructions, #special-browser-page, #disabled-site-message, #firstparty-protections-container {
+.pbInstructions, #special-browser-page, #disabled-site-message, #firstparty-protections-container {
     color: #505050;
     font-size: 16px;
     margin: 0;
     padding-top: 10px;
+    cursor: pointer;
 }
-#pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a {
+.pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a {
     text-decoration: underline;
     color: black;
     font-weight: bold;
 }
-#pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a:hover {
+.pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a:hover {
     color: #ec9329
 }
 #firstparty-protections-container a {
@@ -310,7 +311,7 @@ font-size: 16px;
     font-size: 14px;
     margin-top: -30px;
 }
-#instructions-no-trackers, #special-browser-page, #disabled-site-message {
+#instructions-no-trackers, #special-browser-page, #disabled-site-message, #instructions-many-trackers, #firstparty-protections-container {
     text-align: center;
     margin: 45px 0;
     padding: 0;
@@ -476,7 +477,6 @@ div.overlay.active {
     border-top: 1px solid #707070;
     padding: 0;
     margin: 0;
-    text-align: left;
 }
 #instructions-firstparty-protections {
     margin: 45px 0;
@@ -541,8 +541,8 @@ div.overlay.active {
     }
 
     button,
-    #pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a,
-    #pbInstructions,
+    .pbInstructions :not(#options_domain_list_trackers):not(#options_domain_list_no_trackers) a,
+    .pbInstructions,
     #special-browser-page,
     #disabled-site-message {
         color: #ddd;

diff --git a/src/skin/popup.html b/src/skin/popup.html
@@ -122,15 +122,15 @@ <h2 id="title-name"><span class="i18n_name"></span></h2>
 </div>
 
 <div id="blockedResourcesContainer">
-  <p id="pbInstructions">
+  <p class="pbInstructions">
     <span id="instructions-many-trackers"></span>
     <span id="instructions-no-trackers" style="display:none">
       <span class="i18n_popup_instructions_no_trackers" data-i18n_contents_placeholders="<a target='_blank' title='i18n_what_is_a_tracker' class='tooltip' href='https://privacybadger.org/#What-is-a-third-party-tracker'>"></span>
       <span id="no-third-parties" class="i18n_popup_blocked" style="display:none"></span>
     </span>
     <div id="toggle-blocked-resources-container">
-      <span id="expand-blocked-resources" class="ui-icon ui-icon-caret-d"></span>
-      <span id="collapse-blocked-resources" class="ui-icon ui-icon-caret-u"></span>
+      <span id="expand-blocked-resources" title="i18n_show_more_information" class="ui-icon ui-icon-caret-d tooltip"></span>
+      <span id="collapse-blocked-resources" title="i18n_show_more_information" class="ui-icon ui-icon-caret-u tooltip"></span>
     </div>
   </p>
   <div class="spacer"></div>
@@ -139,9 +139,9 @@ <h2 id="title-name"><span class="i18n_name"></span></h2>
 
 <div id="firstparty-protections-container">
   <div id="instructions-firstparty-protections" class="i18n_popup_info_firstparty_protections popup_info"></div>
-    <div id="toggle-firstparty-info-section">
-      <span id="expand-firstparty-popup" class="ui-icon ui-icon-caret-d"></span>
-      <span id="collapse-firstparty-popup" class="ui-icon ui-icon-caret-u"></span>
+    <div id="toggle-firstparty-info-section" tabIndex="0">
+      <span id="expand-firstparty-popup" title="i18n_show_more_information" class="ui-icon ui-icon-caret-d tooltip"></span>
+      <span id="collapse-firstparty-popup" title="i18n_show_more_information" class="ui-icon ui-icon-caret-u tooltip"></span>
     </div>
   <div id="instructions-firstparty-description" class="i18n_popup_info_firstparty_description"></div>
 </div>