Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the checks for missing installations #795

Open
wants to merge 9 commits into
base: 2023.06-software.eessi.io
Choose a base branch
from

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Oct 18, 2024

This only checks the easystack files that are using the latest releases of EasyBuild (since this is our policy and there is little point in checking older easystacks over and over)

Copy link

eessi-bot bot commented Oct 18, 2024

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

Instance boegel-bot-deucalion is configured to build for:

  • architectures: aarch64/a64fx
  • repositories: eessi.io-2023.06-software

Copy link

eessi-bot bot commented Oct 18, 2024

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software, eessi.io-2023.06-compat

Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine mostly. A few suggestions for the script only_latest_easystacks.sh. Might also be worthwhile to put curly brackets around all variable names.

The one rebuild easystack file that was moved, it was not necessary for this PR, just something you noted?

@@ -0,0 +1,42 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a short header (see other .sh scripts) with:

  • purpose of the script
  • author(s)
  • license

@@ -0,0 +1,42 @@
#!/bin/bash
EESSI_VERSION=${EESSI_VERSION:-"2023.06"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you source init/eessi_defaults you don't have to change the version here later.

Copy link
Member Author

@ocaisa ocaisa Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted this to be configurable in CI via setting the envvar


directory="easystacks/software.eessi.io/${EESSI_VERSION}"
# List of example filenames
files=($(ls "$directory"/*.yml))
Copy link
Collaborator

@trz42 trz42 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While maybe a rare case, but couldn't it happen that one adds a new easystack file with a higher EB version first under accel/...? Then you would run tests for the second highest version, and would not use the new easystack file in the check.

done

# Output the results
[ -n "$ACCEL_EASYSTACKS" ] && echo "${accel_latest_easystacks[@]}" || echo "${cpu_latest_easystacks[@]}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe easier to read if put into standard if, then, else, ...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants