Streamline the checks for missing installations #795
Conversation
|
Instance
|
|
Instance
|
|
Instance
|
There was a problem hiding this comment.
Looks fine mostly. A few suggestions for the script only_latest_easystacks.sh. Might also be worthwhile to put curly brackets around all variable names.
The one rebuild easystack file that was moved, it was not necessary for this PR, just something you noted?
| @@ -0,0 +1,42 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I'd add a short header (see other .sh scripts) with:
- purpose of the script
- author(s)
- license
| @@ -0,0 +1,42 @@ | |||
| #!/bin/bash | |||
| EESSI_VERSION=${EESSI_VERSION:-"2023.06"} | |||
There was a problem hiding this comment.
If you source init/eessi_defaults you don't have to change the version here later.
There was a problem hiding this comment.
I wanted this to be configurable in CI via setting the envvar
|
|
||
| directory="easystacks/software.eessi.io/${EESSI_VERSION}" | ||
| # List of example filenames | ||
| files=($(ls "$directory"/*.yml)) |
There was a problem hiding this comment.
While maybe a rare case, but couldn't it happen that one adds a new easystack file with a higher EB version first under accel/...? Then you would run tests for the second highest version, and would not use the new easystack file in the check.
| done | ||
|
|
||
| # Output the results | ||
| [ -n "$ACCEL_EASYSTACKS" ] && echo "${accel_latest_easystacks[@]}" || echo "${cpu_latest_easystacks[@]}" |
There was a problem hiding this comment.
Maybe easier to read if put into standard if, then, else, ...?
This only checks the easystack files that are using the latest releases of EasyBuild (since this is our policy and there is little point in checking older easystacks over and over)