Fix archdetect: ensure we use instructions introduced with ARM v8.2 for Neoverse N1

[ocaisa]

Fixes #539

On the Raspberry Pi 4, we've seen incorrect matching to Neoverse N1 due to checking an instruction that is actually available with ARM v8.0 (rather than something introduced in ARM v8.2)

[eessi-bot]

Instance eessi-bot-mc-aws is configured to build:

• arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
• arch x86_64/generic for repo eessi-hpc.org-2023.06-software
• arch x86_64/generic for repo eessi.io-2023.06-compat
• arch x86_64/generic for repo eessi.io-2023.06-software
• arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
• arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
• arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
• arch x86_64/intel/haswell for repo eessi.io-2023.06-software
• arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
• arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
• arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
• arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
• arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
• arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
• arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
• arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
• arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
• arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
• arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
• arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
• arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
• arch aarch64/generic for repo eessi-hpc.org-2023.06-software
• arch aarch64/generic for repo eessi.io-2023.06-compat
• arch aarch64/generic for repo eessi.io-2023.06-software
• arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
• arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
• arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
• arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
• arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
• arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
• arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
• arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

[ocaisa]

bot: build repo:eessi.io-2023.06-software arch:x86_64/intel/haswell

[eessi-bot]

Updates by the bot instance eessi-bot-mc-aws (click for details)

• received bot command build repo:eessi.io-2023.06-software arch:x86_64/intel/haswell from ocaisa

  • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/intel/haswell

• handling command build repository:eessi.io-2023.06-software architecture:x86_64/intel/haswell resulted in:

  • submitted job 9342, for details & status see Fix archdetect: ensure we use instructions introduced with ARM v8.2 for Neoverse N1 #540 (comment)

[eessi-bot]

New job on instance eessi-bot-mc-aws for architecture x86_64-intel-haswell for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.04/pr_540/9342

date	job status	comment
Apr 12 11:29:54 UTC 2024	submitted	job id 9342 awaits release by job manager
Apr 12 11:30:41 UTC 2024	released	job awaits launch by Slurm scheduler
Apr 12 11:35:43 UTC 2024	running	job 9342 is running
Apr 12 11:49:56 UTC 2024	finished	😢 FAILURE (click triangle for details) Details ✅ job output file slurm-9342.out ✅ no message matching ERROR: ✅ no message matching FAILED: ✅ no message matching required modules missing: ✅ found message(s) matching No missing installations ✅ found message matching .tar.gz created! Artefacts No artefacts were created or found.
Apr 12 11:49:56 UTC 2024	test result	😁 SUCCESS (click triangle for details) ReFrame Summary [ PASSED ] Ran 9/9 test case(s) from 9 check(s) (0 failure(s), 0 skipped, 0 aborted) Details ✅ job output file slurm-9342.out ✅ no message matching ERROR: ✅ no message matching [\s*FAILED\s*].*Ran .* test case

[ocaisa]

@bedroge So the bot is not picking up on this in the tarball as the file is not being changed in the overlay itself, not sure what to do about that...

[bedroge]

@bedroge So the bot is not picking up on this in the tarball as the file is not being changed in the overlay itself, not sure what to do about that...

It does actually put it into the overlay, but it seems that the tarball step only looks for new files in the haswell subdirectory. Looking at a similar, older PR like #415, we deployed this manually. Let me try that.

[bedroge]

And opened an issue here, as it would be nice/better if the bot can do this for us.
#541

[bedroge]

Manually uploaded the tarball. Verified the contents by doing a diff with the current init dir in the repo:

$ diff -ru 2023.06/init /cvmfs/software.eessi.io/versions/2023.06/init/
diff -ru 2023.06/init/arch_specs/eessi_arch_arm.spec /cvmfs/software.eessi.io/versions/2023.06/init/arch_specs/eessi_arch_arm.spec
--- 2023.06/init/arch_specs/eessi_arch_arm.spec	2024-04-12 16:19:43.000000000 +0200
+++ /cvmfs/software.eessi.io/versions/2023.06/init/arch_specs/eessi_arch_arm.spec	2024-01-24 10:05:10.000000000 +0100
@@ -1,6 +1,6 @@
-# ARM CPU architecture specifications (see https://gpages.juszkiewicz.com.pl/arm-socs-table/arm-socs.html for guidance)
+# ARM CPU architecture specifications
 # Software path in EESSI 	| Vendor ID 	| List of defining CPU features
-"aarch64/neoverse_n1"	"ARM"		"asimddp"		# Ampere Altra
-"aarch64/neoverse_n1"	""		"asimddp"		# AWS Graviton2
-"aarch64/neoverse_v1"	"ARM"		"asimddp svei8mm"
-"aarch64/neoverse_v1"	""		"asimddp svei8mm"	# AWS Graviton3
+"aarch64/neoverse_n1"	"ARM"		"asimd"		# Ampere Altra
+"aarch64/neoverse_n1"	""		"asimd"		# AWS Graviton2
+"aarch64/neoverse_v1"	"ARM"		"asimd svei8mm"
+"aarch64/neoverse_v1"	""		"asimd svei8mm"	# AWS Graviton3

Staging PR should be automatically opened soon...

[bedroge]

Tarball has been ingested.