Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use amrex::SmallMatrix #736

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Use amrex::SmallMatrix #736

merged 3 commits into from
Oct 12, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 10, 2024

Replace current small matrix logic and math with the new amrex::SmallMatrix class.

@ax3l ax3l added component: diagnostics all types of outputs component: elements Elements/external fields labels Oct 10, 2024
@ax3l ax3l force-pushed the topic-small-matrix branch 2 times, most recently from 93ede30 to 502fcc9 Compare October 10, 2024 21:25
@WeiqunZhang
Copy link
Member

AMReX-Codes/amrex#4188

Replace current small matrix logic and math with the new
`amrex::SmallMatrix` class.
More readable dense operation.
Ensure zero init of all non-set values
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! This will make life easier.

@ax3l ax3l enabled auto-merge (squash) October 11, 2024 23:33
@ax3l ax3l merged commit 5f21458 into ECP-WarpX:development Oct 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs component: elements Elements/external fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants