Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeamMonitor: Enable Filtering by Cycle (Turn) #713

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 24, 2024

For modeling of periodic lattices, we can now sub-select the output of particles at the BeamMonitor/beam_monitor element to every N-th period (turn or cycle).

This is first, simple (equidistant) implementation of #662.

To Do

  • implement
  • document
  • add example
  • finalize user-facing naming of filter

@ax3l ax3l added the component: diagnostics all types of outputs label Sep 24, 2024
@ax3l ax3l requested a review from cemitch99 September 24, 2024 19:18
@ax3l ax3l force-pushed the topic-cycle-interval-filter branch 3 times, most recently from 13f11e1 to 1f61fad Compare September 24, 2024 19:22
@ax3l ax3l changed the title Topic cycle interval filter BeamMonitor: Enable Filtering by Turn Sep 24, 2024
@ax3l ax3l changed the title BeamMonitor: Enable Filtering by Turn BeamMonitor: Enable Filtering by Cycle (Turn) Sep 24, 2024
@ax3l ax3l force-pushed the topic-cycle-interval-filter branch from 1f61fad to 5eaa4c8 Compare September 25, 2024 02:22
@ax3l ax3l force-pushed the topic-cycle-interval-filter branch from 0470fc7 to 6d26269 Compare September 26, 2024 21:59
@ax3l ax3l force-pushed the topic-cycle-interval-filter branch from 6d26269 to 987fd3d Compare October 4, 2024 00:09
@ax3l
Copy link
Member Author

ax3l commented Oct 4, 2024

@cemitch99 this is ready for review & merge now :)

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. This is a useful feature to have, thanks.

@cemitch99 cemitch99 merged commit dfe9b28 into ECP-WarpX:development Oct 9, 2024
16 checks passed
@ax3l ax3l deleted the topic-cycle-interval-filter branch October 9, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants