Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename element name to type #710

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 23, 2024

This string just names the type of the element. In #705, we will introduce per-element, user-defined names in a separate PR, which we will use the name field for.

This string just names the type of the element. We will introduce
per-element, user-defined names in a separate PR, which we will use
the `name` field for.
@ax3l ax3l added the component: elements Elements/external fields label Sep 23, 2024
@ax3l ax3l requested a review from cemitch99 September 23, 2024 04:16
@ax3l ax3l enabled auto-merge (squash) September 23, 2024 04:32
@ax3l ax3l merged commit ea151e0 into ECP-WarpX:development Sep 23, 2024
16 checks passed
@ax3l ax3l deleted the topic-element-type-str branch September 23, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: elements Elements/external fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants