Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiFabRegister: use has_vector when possible #5334

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Sep 26, 2024

Follow-up on #5230: use has_vector for vector fields when possible, instead of has on a single direction.

This PR may fix #5305.

@EZoni EZoni added the cleaning Clean code, improve readability label Sep 26, 2024
@EZoni EZoni changed the title MultiFabRegister follow-up: use has_vector when possible MultiFabRegister: use has_vector when possible Sep 26, 2024
@ax3l ax3l self-requested a review September 26, 2024 05:43
@ax3l ax3l self-assigned this Sep 26, 2024
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ax3l ax3l enabled auto-merge (squash) September 26, 2024 05:45
@ax3l ax3l disabled auto-merge September 26, 2024 05:45
@ax3l ax3l merged commit d9935f4 into ECP-WarpX:development Sep 26, 2024
37 checks passed
@EZoni EZoni deleted the use_has_vector branch October 7, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiFabRegister: replace has with has_vector for vectors
2 participants