-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to maxParticleVelocity #5169
Improvements to maxParticleVelocity #5169
Conversation
A question for those more experienced. Is the a reason we need to call OpenMP manually when we're not using GPU? My understanding is that AMReX should be able to use OpenMP just fine within the |
Not sure why CUDA is failing to compile. Can compile with NVCC on my machine without errors. |
bb98c73
to
791c4f2
Compare
Thanks for the PR @archermarx |
This PR improves the functionality of
WarpXParticleContainer::maxParticleVelocity
in two ways.meanParticleVelocity
This PR also adds a version to
MultiParticleContainer
, so the maximum velocity among all particle species can be obtained.As far as I can tell, this function is not used anywhere at the moment. I am however working on another PR which will make use of it, so I thought i would go ahead and send this off for feedback now.