New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PSATD-JRhom with an arbitrary temporal dependency of `J` and `rho`. #5088

Open

oshapoval wants to merge 44 commits into ECP-WarpX:development from oshapoval:psatd_jrom_arbitrary_time_polynoms

Member

oshapoval commented Jul 26, 2024

[WIP] This PR replaces #4263.

oshapoval and others added 30 commits

September 1, 2023 16:13


          Implement PSATD with arbitrary temporal dependency of J and rho.

f7c36b4


          Removed an old abort message.

5b6a747


          Fix compiler warnings

917bfc5


          Fix redundant boolean literal in ternary expression result

227edcb


          Clean up

dfdc383


          Remove unused private field m_dt

d2d906f


          Add current correction and Vay deposition for PSATD-CLm

ce502d0


          Fixed usage of PSATD-JRm with psatd.update_with_rho=0

324d998


          Fix compilation

877241a


          Fix update_with_rho equations

dd3b1dd


          Renamed all coefficients as {Y1, Y2, ..., Y8} to be consistent with P…

87b2148

…SATD-JRm paper


          Renamed class PsatdAlgorithmJArbitraryInTime as PsatdAlgorithmJRm to …

137b06e

…be consistent with PSATD-JRm paper


          Merge branch 'psatd_arbitrary_time_polynoms' of https://github.com/os…

b989298

…hapoval/WarpX into psatd_arbitrary_time_polynoms


          Renamed PsatdAlgorithmJArbitraryInTime.H/.cpp files as PsatdAlgorithm…

9a49e58

…JRm.H/.cpp


          Separated Class for Galilean PSATD Algorithm (credits to E.Zoni)

fa61e64


          Renamed missed coefficients

da4cb42


          Added CI tests for uniform plasma using PSATD-CC2 and PSATD-QQ2

b5d18be


          Merge remote-tracking branch 'origin/development' into psatd_arbitrar…

7f04d73

…y_time_polynoms


          Added 2D Langmuir CI tets for: PSATD-CC2, PSATD-LL1 (nodal, staggered…

1ba669a

…), PSATD-LQ1, PSATD-QQ1


          Added 3D uniform plasma CI test for PSATD-LL1, and clean-up.

dd8b852


          Merge remote-tracking branch 'origin/development' into psatd_arbitrar…

ad2a58b

…y_time_polynoms


          Added missing div_e_cleaning=1 as an input parameter for 2D Langmuir …

…CI tests: PSATD-LL1, CL1, CC2, QQ1 & .json files


          Fixed typo: removed unnessesary symbol

444fcbf


          Updated CI benchmarks for 2D Langmuir tests using PSATD: LL1, LL1_nod…

156e24b

…al, LQ1_nodal, CC2_nodal and QQ1_nodal


          Updated benchmarks for CI test: uniform_plasma_psatd_LL1

d427e66


          Merge remote-tracking branch 'origin/development' into psatd_arbitrar…

154cf0d

…y_time_polynoms


          Renamed 'multi_j' folder to 'psatd_JRm'.

9576af3


          Renamed file name.

8d334d5


          Renamed all multi-J related parameters and tests names (using new alg…

a127d8a

…orithm abreviaton of psatd-JRm).


          Removed two classes: PsatdAlgorithmJConstantInTime and PsatdAlgorithm…

3582dec

…JLinearInTime. Now we have one class PSATD-JRm.

oshapoval added 6 commits

November 15, 2023 17:07


          Typo fixed.


          Fixed clang_tidy warnings.

8131a15


          Resolving merging conflicts

ce3db9e


          Updated CI benchmarks.

dbfe5f5


          Renamed file from psatd_JRm_rz.json to psatd_LL2_rz.json.

d3fec15


          Merge remote-tracking branch 'origin/development' into psatd_jrom_arb…

83159f1

…itrary_time_polynoms

oshapoval requested a review from EZoni

July 26, 2024 23:06

EZoni added component: spectral enhancement labels


          Clean-up: removed declaration duplication.

6fa619e

EZoni changed the title ~~[WIP] PSATD-JRom with an arbitrary temporal dependency of J and rho.~~ [WIP] PSATD-JRhom with an arbitrary temporal dependency of J and rho.

EZoni self-assigned this

oshapoval added 4 commits

July 26, 2024 17:11


          Renamed the PSATD-JRm algorithm to PSATD-JRhom as it was called and p…

bb4032d

…ublished in the corresponding paper.


          More ranaming PSATD-JRm to PSATD-JRhom.

95142e9


          Changed unsupported anymore WARPX_USE_PSATD to WARPX_USE_FFT.

98c564a


          Updated CI benchmarks for Langmuir_multi_2d_psatd_LL1

1e6f29b

EZoni reviewed

View reviewed changes

Regression/Checksum/benchmarks_json/uniform_plasma_psatd_CC2.json Outdated

Member

EZoni Jul 29, 2024

This file is empty and I think pre-commit doesn't like it. Is it an obsolete file that we can remove or do we need to add checksum values here?

EZoni requested changes

View reviewed changes

Regression/WarpX-tests.ini Outdated

Comment on lines 1189 to 1192

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons positrons

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons positrons

Regression/WarpX-tests.ini Outdated

Comment on lines 1208 to 1211

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons positrons

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons positrons

Regression/WarpX-tests.ini Outdated

Comment on lines 1227 to 1230

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons positrons

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons positrons

Regression/WarpX-tests.ini Outdated

Comment on lines 1246 to 1249

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons positrons

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons positrons

Regression/WarpX-tests.ini Outdated

Comment on lines 1265 to 1268

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons positrons

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons positrons

Regression/WarpX-tests.ini Outdated

Comment on lines 3857 to 3860

+              compileTest = 0
+              doVis = 0
+              compareParticles = 1
+              particleTypes = electrons ions

Member

EZoni Jul 29, 2024

It should be safe to remove these parameters as they are unused, see #5043:

Suggested change

      
            compileTest = 0
          
            doVis = 0
          
            compareParticles = 1
          
            particleTypes = electrons ions

EZoni reviewed

View reviewed changes

Regression/WarpX-tests.ini

Member

EZoni Jul 29, 2024

Maybe we could add JRhom in the name of each new test, too. Something like Langmuir_multi_2d_psatd_JRhom_LL2_first_order, etc., or something along these lines. So that it's clear to everyone that these tests are related to the JRhom options.

Member Author

oshapoval Jul 30, 2024

Sounds good to me. One might also explicitly add to the Documentation section that standard PSATD is equivalent to psatd_JRhom_CL1.

EZoni reviewed

View reviewed changes

Regression/WarpX-tests.ini

Member

EZoni Jul 29, 2024

If #5097 shows that analysisOutputImage is indeed an obsolete, unused parameter, we will remove it from the new tests here as well.

EZoni and others added 3 commits

July 29, 2024 13:57


          Fix clang-tidy build errors

a87e59a


          Removed unused parameters

d055ff9


          Merge branch 'psatd_jrom_arbitrary_time_polynoms' of https://github.c…

dd7b5e6

…om/oshapoval/WarpX into psatd_jrom_arbitrary_time_polynoms

EZoni requested changes

View reviewed changes

Regression/WarpX-tests.ini

@@ @@ -1157,12 +1157,12 @@ numprocs = 2 @@
               useOMP = 1
               numthreads = 1
               analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
-              analysisOutputImage = Langmuir_multi_2d_psatd_multiJ.png
+              analysisOutputImage = Langmuir_multi_2d_psatd_LL2_first_order.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_LL2_first_order.png

Regression/WarpX-tests.ini

@@ @@ -1172,7 +1172,82 @@ numprocs = 2 @@
               useOMP = 1
               numthreads = 1
               analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
-              analysisOutputImage = Langmuir_multi_2d_psatd_multiJ_nodal.png
+              analysisOutputImage = Langmuir_multi_2d_psatd_LL2_first_order_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_LL2_first_order_nodal.png

Regression/WarpX-tests.ini

+              useOMP = 1
+              numthreads = 1
+              analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
+              analysisOutputImage = Langmuir_multi_2d_psatd_CC2_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_CC2_nodal.png

Regression/WarpX-tests.ini

+              useOMP = 1
+              numthreads = 1
+              analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
+              analysisOutputImage = Langmuir_multi_2d_psatd_LL1_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_LL1_nodal.png

Regression/WarpX-tests.ini

+              useOMP = 1
+              numthreads = 1
+              analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
+              analysisOutputImage = Langmuir_multi_2d_psatd_QQ1_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_QQ1_nodal.png

Regression/WarpX-tests.ini

+              useOMP = 1
+              numthreads = 1
+              analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
+              analysisOutputImage = Langmuir_multi_2d_psatd_LQ1_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_LQ1_nodal.png

Regression/WarpX-tests.ini

+              useOMP = 1
+              numthreads = 1
+              analysisRoutine = Examples/Tests/langmuir/analysis_2d.py
+              analysisOutputImage = Langmuir_multi_2d_psatd_LL1.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_2d_psatd_LL1.png

Regression/WarpX-tests.ini

@@ @@ -1337,12 +1412,12 @@ numprocs = 2 @@
               useOMP = 1
               numthreads = 1
               analysisRoutine = Examples/Tests/langmuir/analysis_3d.py
-              analysisOutputImage = Langmuir_multi_psatd_multiJ.png
+              analysisOutputImage = Langmuir_multi_psatd_LL2_first_order.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_psatd_LL2_first_order.png

Regression/WarpX-tests.ini

@@ @@ -1352,7 +1427,7 @@ numprocs = 2 @@
               useOMP = 1
               numthreads = 1
               analysisRoutine = Examples/Tests/langmuir/analysis_3d.py
-              analysisOutputImage = Langmuir_multi_psatd_multiJ_nodal.png
+              analysisOutputImage = Langmuir_multi_psatd_LL2_first_order_nodal.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_psatd_LL2_first_order_nodal.png

Regression/WarpX-tests.ini

@@ @@ -1475,7 +1550,7 @@ numprocs = 2 @@
               useOMP = 1
               numthreads = 1
               analysisRoutine = Examples/Tests/langmuir/analysis_rz.py
-              analysisOutputImage = Langmuir_multi_rz_psatd_multiJ_analysis.png
+              analysisOutputImage = Langmuir_multi_rz_psatd_LL4_analysis.png

Member

EZoni Jul 30, 2024

See https://github.com/ECP-WarpX/WarpX/pull/5088/files#r1695643012:

Suggested change

analysisOutputImage = Langmuir_multi_rz_psatd_LL4_analysis.png

EZoni self-requested a review

July 30, 2024 00:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: spectral enhancement