Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to WarpX::GetInstance() from MacroscopicProperties.cpp #4872

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Remove calls to WarpX::GetInstance() from MacroscopicProperties.cpp #4872

merged 2 commits into from
Apr 24, 2024

Conversation

lucafedeli88
Copy link
Member

@lucafedeli88 lucafedeli88 commented Apr 19, 2024 •
edited by ax3l
Loading

This PR removes calls to WarpX::GetInstance() from MacroscopicProperties.cpp

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Apr 19, 2024
@ax3l ax3l self-assigned this Apr 22, 2024
@ax3l ax3l self-requested a review April 22, 2024 23:13
@lucafedeli88
Merge remote-tracking branch 'upstream/development' into remove_calls…
cda66e8 
…_to_warpx_get_instance_from_macroscopic_properties
@ax3l ax3l changed the title Remove calls to WarpX:GetInstance() from MacroscopicProperties.cpp Remove calls to WarpX::GetInstance() from MacroscopicProperties.cpp Apr 24, 2024
ax3l
ax3l approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✨

@ax3l ax3l merged commit 7e65117 into ECP-WarpX:development Apr 24, 2024
45 checks passed
Haavaan pushed a commit to Haavaan/WarpX that referenced this pull request Jun 5, 2024
@lucafedeli88 @Haavaan
remove calls to WarpX:GetInstance() from MacroscopicProperties.cpp (E…
3af25dd 
…CP-WarpX#4872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
cleaning Clean code, improve readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucafedeli88 @ax3l