Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PSATD: less radial ghost cells by default in RZ #4259

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[WIP] PSATD: less radial ghost cells by default in RZ #4259

wants to merge 2 commits into from

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Sep 1, 2023

In RZ geometry, there is no domain decomposition along r, hence no need to account for the extent of the spectral stencil along that direction. Note that some variables were also renamed from ngFFt_... to ngFFT_..., the lower-case t looked like a typo.

@RemiLehe @dpgrote
Is this what you had in mind?

@EZoni
PSATD: less radial ghost cells by default in RZ
95c0439 
In RZ geometry, no domain decomposition along r,
no need to account for extent of spectral stencil
@EZoni EZoni added component: spectral Spectral solvers (PSATD, IGF) component: parallelization Guard cell exchanges and particle redistribution geometry: RZ axisymmetric 2D and quasi-3D labels Sep 1, 2023
dpgrote
dpgrote approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@dpgrote dpgrote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok for me, but also let Remi review.

Though it is failing two tests. The differences look like round-off errors, but it's not clear why the round-off would be different.

@EZoni
Copy link
Member Author

EZoni commented Sep 1, 2023

I agree with the fact that it's not fully understood why this would change the checksums of some PSATD tests.

@RemiLehe RemiLehe self-assigned this Sep 11, 2023
@RemiLehe
Copy link
Member

In offline discussion: is this OK with we use damped in the r direction?

@EZoni EZoni changed the title PSATD: less radial ghost cells by default in RZ [WIP] PSATD: less radial ghost cells by default in RZ Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgrote dpgrote dpgrote approved these changes

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

Assignees

@RemiLehe RemiLehe

Labels
component: parallelization Guard cell exchanges and particle redistribution component: spectral Spectral solvers (PSATD, IGF) geometry: RZ axisymmetric 2D and quasi-3D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EZoni @RemiLehe @dpgrote