Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read wavelength and flag 'isLaserEnvelope' from lasy file #3957

Draft
wants to merge 62 commits into
base: development
Choose a base branch
from

Conversation

IlianCS
Copy link
Member

@IlianCS IlianCS commented May 31, 2023

Next implementations for lasy files reading, following #3910

Files that need to be changed:

LaserProfiles.H
LaserProfileFromFile.cpp
LaserProfileGaussian.cpp
LaserProfileFieldFunction.cpp
LaserParticleContainer.cpp

Originally we wanted to read the wavelength, polarization and e_max from the lasy file. We also wanted to read the full field if isLaserEnvelope is set to False in the file.

Update: We are not looking for reading the polarization and e_max in the file anymore.
e_max: we are waiting for e_max to be stored inside the lasy file because we don't want to loop over the whole file in WarpX in order to compute it.
polarization: complex meta data set by the user when creating a lasy file to define, for instance, circular and elliptical lasers. As WarpX is not able to read complex polarization, we cannot read this attribute so we let it as a choice for the user to provide a linear polarization in the inputs file.
isLaserEnvelope: we want to read the boolean inside the lasy file but lasy does not have the capability yet to store the amplitude instead of the envelope.

TODO list (updated):

  • Read wavelength from file.
  • Read the flag isLaserEnvelope.

IlianCS and others added 30 commits May 8, 2023 18:41
pre-commit-ci bot and others added 24 commits May 18, 2023 18:32
@IlianCS IlianCS changed the title Read wavelength and isLaserEnvelope from lasy file Read wavelength and flag 'isLaserEnvelope' from lasy file Jun 1, 2023
@ax3l ax3l requested review from ax3l and RemiLehe June 5, 2023 18:30
@ax3l
Copy link
Member

ax3l commented Jun 5, 2023

cc @MaxThevenet @RemiLehe I think this might need an addition of a few attributes in the openPMD laser envelope extension? Did we already start discussing this, sounds like a good idea :)

https://github.com/openPMD/openPMD-standard/blob/upcoming-2.0.0/EXT_LaserEnvelope.md

@ax3l ax3l added the component: openPMD openPMD I/O label Jun 5, 2023
@ax3l ax3l requested a review from MaxThevenet June 5, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants