Fixing staircased EM solver #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgiacome
added
component: boundary
for more information, see https://pre-commit.ci
RemiLehe
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the staircased EM solver we had redundant checks on B ensure it is zero inside conductors, but this is not needed because it follows from the fact that E is zero everywhere inside the conductor and on its surface.
When the EB boundary is not aligned with the grid, checking also B leads to inconsistencies so we remove the checks on B completely.
We also remove the checks in the PML damping as they are clearly redundant.
The way the staircased EB is implemented in this PR is exactly the same as in Warp.