Feature/build system #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lleon95
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Please, add placeholder files to compile a shared library. It will help you to define some code that it is not currently defined here.
Moreover, create an examples directory where you can define a small application that links to the shared library so you can check the building system
lleon95
requested changes
Oct 31, 2023
|
Please, merge those commits which are targeting an objective. For instance:
The 22 commits are actually those two. |
add placeholder files.
dierpg
force-pushed
the
feature/build-system
branch
from
b2fb077 to
262c1f3
Compare
add placeholder files.
lleon95
requested changes
Nov 1, 2023
…eature/build-system
dierpg
force-pushed
the
feature/build-system
branch
from
2c3f037 to
cb6ef02
Compare
lleon95
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the following: