Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change session rule #52

Merged
merged 4 commits into from
Jul 18, 2017
Merged

Change session rule #52

merged 4 commits into from
Jul 18, 2017

Conversation

lqdung-lockon
Copy link
Contributor

@lqdung-lockon lqdung-lockon commented Jul 12, 2017 •
edited
Loading

Change the session rule to follow the official source code.

Test:

  • Eccube 3.0.12 - 3.0.13 - 3.0.14 - 3.0.15
  • Mysql
  • Pgsql
  • Travis

@coveralls
Copy link

coveralls commented Jul 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 84.746% when pulling 9478261 on eccubevn:change_session into e602190 on EC-CUBE:master.

t-nagahashi
t-nagahashi approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@t-nagahashi t-nagahashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソースコードOKです。

@coveralls
Copy link

coveralls commented Jul 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 84.746% when pulling e508a88 on eccubevn:change_session into e602190 on EC-CUBE:master.

t-nagahashi
t-nagahashi approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@t-nagahashi t-nagahashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソースコードOKです。

@t-nagahashi
Copy link
Contributor

動作確認OKです。

・検索条件を追加し、検索結果が正常に表示されることを確認
・検索時のSQLが、修正前後で同じであることを確認

@t-nagahashi t-nagahashi merged commit 45a2b14 into EC-CUBE:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-nagahashi t-nagahashi t-nagahashi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lqdung-lockon @coveralls @t-nagahashi