Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

入力が無い場合にも PREF_CHECK がエラー判定となってしまうのを修正 #1113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanasess
Copy link
Contributor

Fixes #744

PREF_CHECK の挙動が変わるが、 PREF_CHECK は以下でのみ使用されており、 EXIST_CHECK と併用されているため問題ないと思われる

$objFormParam->addParam('都道府県', $prefix.'pref', INT_LEN, 'n', ['PREF_CHECK', 'EXIST_CHECK', 'NUM_CHECK']);

@nanasess nanasess added this to the 2.18(仮) milestone Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.61%. Comparing base (1a66910) to head (9e46652).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   50.60%   50.61%           
=======================================
  Files          80       80           
  Lines       10258    10260    +2     
=======================================
+ Hits         5191     5193    +2     
  Misses       5067     5067           
Flag Coverage Δ
tests 50.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess enabled auto-merge December 26, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PREF_CHECK が未入力を許容していない
2 participants