-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zapシナリオ追加 #6198
Merged
Merged
zapシナリオ追加 #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6198 +/- ##
==========================================
+ Coverage 82.76% 82.79% +0.02%
==========================================
Files 480 480
Lines 26431 26419 -12
==========================================
- Hits 21876 21873 -3
+ Misses 4555 4546 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZAPテスト完了後にマージしたいと思います。 |
nanasess
reviewed
May 24, 2024
実行の仕方をコメントに追加 |
shinya
approved these changes
Jun 12, 2024
dotani1111
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
本体にZAPのシナリオを追加
方針(Policy)
実装に関する補足(Appendix)
4.3で新たに追加したシナリオ
・メールテンプレートを新規登録できるように対応 #6140
admin_mail_edit.zst
・規格・規格分類:「CSV登録」作成, 「CSVダウンロード・CSV出力項目設定」追加 #5043
admin_class_category_csv.zst
admin_class_name_csv.zst
・新着商品ブロックにて、商品を動的に表示する #4920
front_new_item.zst
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目