-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
デフォルトテンプレートの修正 #5639
Merged
chihiro-adachi
merged 8 commits into
EC-CUBE:4.2
from
tsumu-tsumu:20220822_default_template
Sep 6, 2022
Merged
デフォルトテンプレートの修正 #5639
chihiro-adachi
merged 8 commits into
EC-CUBE:4.2
from
tsumu-tsumu:20220822_default_template
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.2 #5639 +/- ##
=========================================
Coverage 78.85% 78.85%
Complexity 6275 6275
=========================================
Files 469 469
Lines 21078 21078
=========================================
+ Hits 16621 16622 +1
+ Misses 4457 4456 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit c09837a.
chihiro-adachi
force-pushed
the
20220822_default_template
branch
from
September 6, 2022 00:13
c2d655b
to
2de27b6
Compare
@tsumu-tsumu |
chihiro-adachi
added
bug:Low
Status: ready-for-merge
and removed
Status: needs-review
labels
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
デフォルトテンプレート、インストール画面のデザイン修正
方針(Policy)
- 4.1のデザインに合わせた画面修正を行いました。
実装に関する補足(Appendix)
インストール画面のbadge-danger(bootstrap4の名前)のclass名をbg-danger(bootstrap5の名前)に変更する方法がわからず、badge-dangerにbg-dangerのcssを当てました。
サイトURL/mypage/history/id
こちらの戻るボタンは4.1と比較しマークアップ が変わっておりましたので、4.1に合わせる形で修正しております。
テスト(Test)
4.1と比較しデザイン崩れがないことを確認
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目