Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply composer update #5519

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Apply composer update #5519

merged 4 commits into from
Aug 9, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Aug 8, 2022

概要(Overview・Refs Issue)

composer update を適用

  • Upgrading symfony/flex (v1.18.5 => v1.19.2)
  • Upgrading symfony/polyfill-mbstring (v1.25.0 => v1.26.0)
  • Upgrading symfony/polyfill-iconv (v1.25.0 => v1.26.0)
  • Upgrading zbateson/mb-wrapper (1.1.1 => 1.1.2)
  • Upgrading guzzlehttp/psr7 (2.2.1 => 2.4.0)
  • Upgrading symfony/deprecation-contracts (v2.5.1 => v2.5.2)
  • Upgrading guzzlehttp/guzzle (7.4.4 => 7.4.5)
  • Upgrading symfony/polyfill-ctype (v1.25.0 => v1.26.0)
  • Upgrading symfony/yaml (v5.4.3 => v5.4.11)
  • Upgrading symfony/polyfill-php80 (v1.25.0 => v1.26.0)
  • Upgrading symfony/finder (v5.4.3 => v5.4.11)
  • Upgrading symfony/event-dispatcher-contracts (v2.5.1 => v2.5.2)
  • Upgrading symfony/event-dispatcher (v5.4.3 => v5.4.9)
  • Upgrading symfony/css-selector (v5.4.3 => v5.4.11)
  • Upgrading symfony/polyfill-intl-normalizer (v1.25.0 => v1.26.0)
  • Upgrading symfony/polyfill-intl-grapheme (v1.25.0 => v1.26.0)
  • Upgrading symfony/string (v5.4.3 => v5.4.11)
  • Upgrading symfony/service-contracts (v2.5.1 => v2.5.2)
  • Upgrading symfony/polyfill-php73 (v1.25.0 => v1.26.0)
  • Upgrading symfony/console (v5.4.7 => v5.4.11)
  • Upgrading nikic/php-parser (v4.13.2 => v4.14.0)
  • Upgrading webmozart/assert (1.10.0 => 1.11.0)
  • Upgrading phpunit/phpunit (9.5.20 => 9.5.21)
  • Upgrading codeception/phpunit-wrapper (9.0.7 => 9.0.9)
  • Upgrading codeception/codeception (4.1.31 => 4.2.1)
  • Upgrading captbaritone/mailcatcher-codeception-module (2.4.0 => 2.4.1)
  • Upgrading symfony/dom-crawler (v5.4.6 => v5.4.11)
  • Upgrading symfony/browser-kit (v5.4.3 => v5.4.11)
  • Upgrading codeception/module-phpbrowser (1.0.2 => 1.0.3)
  • Upgrading symfony/process (v5.4.7 => v5.4.11)
  • Upgrading php-webdriver/webdriver (1.12.0 => 1.12.1)
  • Upgrading symfony/filesystem (v5.4.7 => v5.4.11)
  • Upgrading composer/spdx-licenses (1.5.6 => 1.5.7)
  • Upgrading composer/ca-bundle (1.3.1 => 1.3.3)
  • Upgrading composer/composer (2.3.5 => 2.3.10)
  • Upgrading symfony/routing (v5.4.3 => v5.4.11)
  • Upgrading symfony/polyfill-php81 (v1.25.0 => v1.26.0)
  • Upgrading symfony/http-foundation (v5.4.6 => v5.4.11)
  • Upgrading symfony/var-dumper (v5.4.6 => v5.4.11)
  • Upgrading symfony/error-handler (v5.4.7 => v5.4.11)
  • Upgrading symfony/http-kernel (v5.4.7 => v5.4.11)
  • Upgrading symfony/dependency-injection (v5.4.7 => v5.4.11)
  • Upgrading symfony/config (v5.4.7 => v5.4.11)
  • Upgrading symfony/var-exporter (v5.4.7 => v5.4.10)
  • Upgrading symfony/cache-contracts (v2.5.1 => v2.5.2)
  • Upgrading symfony/cache (v5.4.7 => v5.4.11)
  • Upgrading symfony/framework-bundle (v5.4.7 => v5.4.11)
  • Upgrading doctrine/event-manager (1.1.1 => 1.1.2)
  • Upgrading doctrine/deprecations (v0.5.3 => v1.0.0)
  • Upgrading doctrine/cache (2.1.1 => 2.2.0)
  • Upgrading doctrine/persistence (2.5.0 => 2.5.4)
  • Upgrading symfony/doctrine-bridge (v5.4.7 => v5.4.11)
  • Upgrading doctrine/sql-formatter (1.1.2 => 1.1.3)
  • Upgrading doctrine/dbal (3.3.5 => 3.3.7)
  • Upgrading doctrine/annotations (1.13.2 => 1.13.3)
  • Upgrading doctrine/doctrine-bundle (2.6.2 => 2.7.0)
  • Upgrading symfony/polyfill-php72 (v1.25.0 => v1.26.0)
  • Upgrading doctrine/common (3.2.2 => 3.3.0)
  • Upgrading doctrine/orm (2.11.2 => 2.12.3)
  • Upgrading doctrine/data-fixtures (1.5.2 => 1.5.3)
  • Upgrading doctrine/doctrine-fixtures-bundle (3.4.1 => 3.4.2)
  • Upgrading laminas/laminas-code (4.5.1 => 4.6.0)
  • Upgrading friendsofphp/proxy-manager-lts (v1.0.7 => v1.0.12)
  • Upgrading doctrine/migrations (3.5.0 => 3.5.1)
  • Upgrading monolog/monolog (2.5.0 => 2.8.0)
  • Upgrading fakerphp/faker (v1.19.0 => v1.20.0)
  • Upgrading symfony/options-resolver (v5.4.3 => v5.4.11)
  • Upgrading friendsofphp/php-cs-fixer (v3.8.0 => v3.9.5)
  • Upgrading symfony/translation-contracts (v2.5.1 => v2.5.2)
  • Upgrading symfony/translation (v5.4.7 => v5.4.11)
  • Upgrading mikey179/vfsstream (v1.6.10 => v1.6.11)
  • Upgrading nesbot/carbon (2.57.0 => 2.60.0)
  • Upgrading phpstan/phpstan (1.7.2 => 1.8.2)
  • Upgrading symfony/twig-bridge (v5.4.7 => v5.4.11)
  • Upgrading symfony/debug-bundle (v5.4.3 => v5.4.11)
  • Upgrading symfony/expression-language (v5.4.7 => v5.4.11)
  • Upgrading symfony/property-info (v5.4.7 => v5.4.11)
  • Upgrading symfony/property-access (v5.4.7 => v5.4.11)
  • Upgrading symfony/polyfill-intl-icu (v1.25.0 => v1.26.0)
  • Upgrading symfony/form (v5.4.7 => v5.4.11)
  • Upgrading symfony/inflector (v5.4.3 => v5.4.11)
  • Upgrading symfony/polyfill-intl-idn (v1.25.0 => v1.26.0)
  • Upgrading symfony/mime (v5.4.8 => v5.4.11)
  • Upgrading symfony/mailer (v5.4.8 => v5.4.11)
  • Upgrading symfony/maker-bundle (v1.38.0 => v1.43.0)
  • Upgrading symfony/monolog-bridge (v5.4.3 => v5.4.10)
  • Upgrading symfony/monolog-bundle (v3.7.1 => v3.8.0)
  • Upgrading symfony/phpunit-bridge (v5.4.7 => v5.4.11)
  • Upgrading symfony/rate-limiter (v5.4.9 => v5.4.11)
  • Upgrading symfony/password-hasher (v5.4.3 => v5.4.11)
  • Upgrading symfony/security-core (v5.4.7 => v5.4.11)
  • Upgrading symfony/security-http (v5.4.5 => v5.4.11)
  • Upgrading symfony/security-guard (v5.4.3 => v5.4.9)
  • Upgrading symfony/security-csrf (v5.4.3 => v5.4.11)
  • Upgrading symfony/security-bundle (v5.4.5 => v5.4.11)
  • Upgrading symfony/serializer (v5.4.7 => v5.4.11)
  • Upgrading symfony/templating (v5.4.3 => v5.4.11)
  • Upgrading symfony/validator (v5.4.7 => v5.4.11)
  • Upgrading symfony/twig-bundle (v5.4.3 => v5.4.8)
  • Upgrading symfony/web-profiler-bundle (v5.4.6 => v5.4.10)
  • Upgrading symfony/workflow (v5.4.3 => v5.4.11)
  • Upgrading twig/extra-bundle (v3.3.8 => v3.4.0)
  • Upgrading symfony/intl (v5.4.5 => v5.4.11)
  • Upgrading twig/intl-extra (v3.3.5 => v3.4.0)
  • Upgrading phpoption/phpoption (1.8.1 => 1.9.0)
  • Upgrading graham-campbell/result-type (v1.0.4 => v1.1.0)

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

GitHub Actions が通るのを確認

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更はありません
  • フックポイントの呼び出しタイミングの変更はありません
  • フックポイントのパラメータの削除・データ型の変更はありません
  • twigファイルに渡しているパラメータの削除・データ型の変更はありません
  • Serviceクラスの公開関数の、引数の削除・データ型の変更はありません
  • 入出力ファイル(CSVなど)のフォーマット変更はありません

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか
    • 権限を超えた操作が可能にならないか
    • 不要なファイルアップロードがないか
    • 外部へ公開されるファイルや機能の追加ではないか
    • テンプレートでのエスケープ漏れがないか

chihiro-adachi and others added 4 commits August 2, 2022 16:04
- see symfony/symfony#46317
- _target_path 及び _failure_path はURLまたはパスを指定する必要がある
- アプリケーション範囲外の URL を指定された場合は homepage へリダイレクトする
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #5519 (09cd34a) into 4.2 (8545d89) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##                4.2    #5519   +/-   ##
=========================================
  Coverage     78.80%   78.81%           
  Complexity     6246     6246           
=========================================
  Files           468      468           
  Lines         20981    20981           
=========================================
+ Hits          16535    16537    +2     
+ Misses         4446     4444    -2     
Flag Coverage Δ
E2E 64.77% <50.00%> (ø)
Unit 77.51% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php 73.33% <50.00%> (ø)
...hentication/EccubeAuthenticationFailureHandler.php 57.14% <0.00%> (-28.58%) ⬇️
...hentication/EccubeAuthenticationSuccessHandler.php 57.14% <0.00%> (-28.58%) ⬇️
src/Eccube/Repository/OrderRepository.php 95.16% <0.00%> (+2.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chihiro-adachi
Copy link
Contributor

@nanasess
ご対応ありがとうございます!

@chihiro-adachi chihiro-adachi merged commit c3ecb92 into 4.2 Aug 9, 2022
@chihiro-adachi chihiro-adachi deleted the update-composer branch August 9, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants