-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBの文字コードをutf8mb4に対応 #4796
Merged
Merged
DBの文字コードをutf8mb4に対応 #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
chihiro-adachi
force-pushed
the
feature-utf8mb4
branch
from
June 3, 2022 07:17
9823aec
to
42925dc
Compare
@k-yamamura 一部修正かけています。
|
@nanasess |
@chihiro-adachi 手元の環境では、大元の charset を diff --git a/app/config/eccube/packages/doctrine.yaml b/app/config/eccube/packages/doctrine.yaml
index e52cd87129..372f428cdb 100644
--- a/app/config/eccube/packages/doctrine.yaml
+++ b/app/config/eccube/packages/doctrine.yaml
@@ -9,7 +9,7 @@ doctrine:
dbal:
driver: 'pdo_sqlite'
server_version: "%env(DATABASE_SERVER_VERSION)%"
- charset: 'utf8'
+ charset: 'utf8mb4'
# for mysql only
default_table_options: charset も env で設定するか、何とかして動的に設定しないといけないかもしれないです |
chihiro-adachi
force-pushed
the
feature-utf8mb4
branch
from
June 7, 2022 06:56
42925dc
to
7ac8bfb
Compare
@chihiro-adachi 設定できるようになりました |
nanasess
approved these changes
Jun 7, 2022
@nanasess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
レンタルサーバでもutf8mb4を扱えるDBが増えてきたため、
MySQLの標準文字コードをutf8mb4でインストールするように対応
#4525
実装に関する補足(Appendix)
2系や3系からutf8の文字コードを利用しているDBを移行してきても特に影響はなさそう。
相談(Discussion)
初期インストールであれば問題ないが、
バージョンアップ時に、
dtb_productの
note
description_list
description_detail
search_word
の型変更は必要かどうか。
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目