Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang 3.8 and 3.9 added #110

Closed
wants to merge 2 commits into from

Conversation

InderKaur
Copy link

New versions of clang are added to .travis.yml file. #105

@jmmut
Copy link
Contributor

jmmut commented Feb 1, 2018

why both 3.8 and 3.9? each compiler we add makes the build slower, so we have to justify each addition. I didn't have time to check which version is used by default in newer linuxes and newer OSXs.

@cyenyxe
Copy link
Contributor

cyenyxe commented Feb 1, 2018

Clang 4 and 5 are now supported in Travis, see travis-ci/apt-package-safelist#3297 and travis-ci/apt-package-safelist#4034

What I think we should do is to deprecate some of the oldest versions by checking what is the last Ubuntu LTS onwards, and add these more modern ones to the build. I would also keep at least one 3.x version.

@InderKaur
Copy link
Author

I have done the requested changes. please have a look

@cyenyxe
Copy link
Contributor

cyenyxe commented Feb 5, 2018

Any particular reason why you have left the oldest Clang 3.x version?

Copy link
Contributor

@jmmut jmmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing to the project, but there are some things that have to be done before we can merge it:

@Anishka0107
Copy link
Contributor

The latest version of clang I can see in ubuntu trusty is 3.9 (https://packages.ubuntu.com/trusty/devel/)

Maybe this could help you in installing clang 4.0 in trusty: https://superuser.com/questions/1280068/how-do-i-install-clang-4-0-on-ubuntu-14-04

See this too, for further information: https://apt.llvm.org

But I'm not sure, I'm not very familiar with Ubuntu.

@cyenyxe
Copy link
Contributor

cyenyxe commented Mar 5, 2018

Closed due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants