-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang 3.8 and 3.9 added #110
Conversation
why both 3.8 and 3.9? each compiler we add makes the build slower, so we have to justify each addition. I didn't have time to check which version is used by default in newer linuxes and newer OSXs. |
Clang 4 and 5 are now supported in Travis, see travis-ci/apt-package-safelist#3297 and travis-ci/apt-package-safelist#4034 What I think we should do is to deprecate some of the oldest versions by checking what is the last Ubuntu LTS onwards, and add these more modern ones to the build. I would also keep at least one 3.x version. |
I have done the requested changes. please have a look |
Any particular reason why you have left the oldest Clang 3.x version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for contributing to the project, but there are some things that have to be done before we can merge it:
- first of all, travis has to pass (look at the red "X"). It's failing now because clang 4 and 5 are not available in apt-get repositories (https://travis-ci.org/EBIvariation/vcf-validator/builds/337655482?utm_source=github_status&utm_medium=notification). try googling on how to install those versions in ubuntu trusty (the OS used by travis).
- keep only the newest version for each major release (e.g. keep 3.9 as the only 3.x release)
The latest version of clang I can see in ubuntu trusty is 3.9 (https://packages.ubuntu.com/trusty/devel/) Maybe this could help you in installing clang 4.0 in trusty: https://superuser.com/questions/1280068/how-do-i-install-clang-4-0-on-ubuntu-14-04 See this too, for further information: https://apt.llvm.org But I'm not sure, I'm not very familiar with Ubuntu. |
Closed due to lack of activity. |
New versions of clang are added to .travis.yml file. #105